From f8fd4a425309492e60c53133dc899ae3aa92914a Mon Sep 17 00:00:00 2001 From: Benny Baumann Date: Tue, 20 Feb 2018 21:37:45 +0100 Subject: [PATCH] fix: resource leaks in OCSPIssuerManager Change-Id: I15aa074af09c07b72ddb953fa8d1f63b6ae3eb88 --- src/club/wpia/gigi/ocsp/OCSPIssuerManager.java | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/club/wpia/gigi/ocsp/OCSPIssuerManager.java b/src/club/wpia/gigi/ocsp/OCSPIssuerManager.java index 400737f0..36343371 100644 --- a/src/club/wpia/gigi/ocsp/OCSPIssuerManager.java +++ b/src/club/wpia/gigi/ocsp/OCSPIssuerManager.java @@ -225,7 +225,9 @@ public class OCSPIssuerManager implements Runnable { if (ks.length() == 0) { keys.load(null); } else { - keys.load(new FileInputStream(ks), "pass".toCharArray()); + try (FileInputStream ks_file = new FileInputStream(ks)) { + keys.load(ks_file, "pass".toCharArray()); + } } } else { // assuming ocsp is disabled @@ -239,8 +241,8 @@ public class OCSPIssuerManager implements Runnable { Map toServe = new HashMap<>(); scanAndUpdateCAs(f, keys, toServe); - try { - keys.store(new FileOutputStream(ks), "pass".toCharArray()); + try (FileOutputStream ks_file = new FileOutputStream(ks)) { + keys.store(ks_file, "pass".toCharArray()); } catch (GeneralSecurityException e) { throw new Error(e); } catch (IOException e) { -- 2.39.2