From 575b68a79c66f34a6f7dfc2c0c361df5ec35684e Mon Sep 17 00:00:00 2001 From: =?utf8?q?Felix=20D=C3=B6rre?= Date: Sun, 22 Feb 2015 01:34:15 +0100 Subject: [PATCH] Fix: exceptional resource leaks. --- util-testing/org/cacert/gigi/util/SimpleSigner.java | 4 +++- util/org/cacert/gigi/util/FetchLocales.java | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/util-testing/org/cacert/gigi/util/SimpleSigner.java b/util-testing/org/cacert/gigi/util/SimpleSigner.java index 1c635c2e..c6f4660f 100644 --- a/util-testing/org/cacert/gigi/util/SimpleSigner.java +++ b/util-testing/org/cacert/gigi/util/SimpleSigner.java @@ -305,7 +305,9 @@ public class SimpleSigner { Process p1 = Runtime.getRuntime().exec(call, null, new File("keys/unassured.ca")); int waitFor = p1.waitFor(); - f.delete(); + if ( !f.delete()) { + System.err.println("Could not delete SAN-File " + f.getAbsolutePath()); + } if (waitFor == 0) { try (InputStream is = new FileInputStream(crt)) { CertificateFactory cf = CertificateFactory.getInstance("X.509"); diff --git a/util/org/cacert/gigi/util/FetchLocales.java b/util/org/cacert/gigi/util/FetchLocales.java index 87beaace..21a789f3 100644 --- a/util/org/cacert/gigi/util/FetchLocales.java +++ b/util/org/cacert/gigi/util/FetchLocales.java @@ -35,7 +35,9 @@ public class FetchLocales { public static void main(String[] args) throws IOException, ParserConfigurationException, TransformerException { System.out.println("downloading locales ..."); File locale = new File("locale"); - locale.mkdir(); + if ( !locale.mkdir()) { + throw new IOException("Could not create locales directory."); + } DocumentBuilderFactory dbf = DocumentBuilderFactory.newInstance(); DocumentBuilder db = dbf.newDocumentBuilder(); -- 2.39.2