From 06bac02e65bdc2cedb4e70627e179a5689ff94a0 Mon Sep 17 00:00:00 2001
From: =?utf8?q?Felix=20D=C3=B6rre?= <felix@dogcraft.de>
Date: Sat, 13 Aug 2016 23:52:26 +0200
Subject: [PATCH] upd: refactor FindUserByEmail to have two separate templates

Change-Id: I20f80a92be83a9bd84d0a925d77761269d36c0e4
---
 .../pages/admin/support/FindUserByEmailForm.templ    | 12 ------------
 .../pages/admin/support/FindUserByEmailPage.java     | 12 ++++++------
 .../admin/support/FindUserByEmailUsertable.templ     |  8 ++++++++
 3 files changed, 14 insertions(+), 18 deletions(-)
 create mode 100644 src/org/cacert/gigi/pages/admin/support/FindUserByEmailUsertable.templ

diff --git a/src/org/cacert/gigi/pages/admin/support/FindUserByEmailForm.templ b/src/org/cacert/gigi/pages/admin/support/FindUserByEmailForm.templ
index 8563721e..90a627e3 100644
--- a/src/org/cacert/gigi/pages/admin/support/FindUserByEmailForm.templ
+++ b/src/org/cacert/gigi/pages/admin/support/FindUserByEmailForm.templ
@@ -1,14 +1,3 @@
-<? if($usertable) {?>
-<p>Multiple users where found.</p>
-<table class="table">
-<tr>
-<th>Id</th><th>E-Mail</th></tr>
-<? foreach($usertable) {?>
-	<tr><td><a href="/support/user/<?=$usrid?>/"><?=$usrid?></a></td><td><a href="/support/user/<?=$usrid?>/"><?=$usermail?></a></td></tr>
-<? } ?>
-</table>
-<? } ?>
-<? if($first) {?>
 <table class="table">
   <tbody><tr>
     <th colspan="2"><?=_Find User by Email?></th>
@@ -21,4 +10,3 @@
     <td colspan="2"><input name="process" value="<?=_Next?>" type="submit"/></td>
   </tr>
 </tbody></table>
-<? } ?>
diff --git a/src/org/cacert/gigi/pages/admin/support/FindUserByEmailPage.java b/src/org/cacert/gigi/pages/admin/support/FindUserByEmailPage.java
index 85e69a33..ace7888a 100644
--- a/src/org/cacert/gigi/pages/admin/support/FindUserByEmailPage.java
+++ b/src/org/cacert/gigi/pages/admin/support/FindUserByEmailPage.java
@@ -12,6 +12,7 @@ import org.cacert.gigi.dbObjects.EmailAddress;
 import org.cacert.gigi.localisation.Language;
 import org.cacert.gigi.output.template.Form;
 import org.cacert.gigi.output.template.IterableDataset;
+import org.cacert.gigi.output.template.Template;
 import org.cacert.gigi.pages.Page;
 import org.cacert.gigi.util.AuthorizationContext;
 
@@ -19,15 +20,15 @@ public class FindUserByEmailPage extends Page {
 
     public static final String PATH = "/support/find/email";
 
+    private static final Template USERTABLE = new Template(FindUserByDomainPage.class.getResource("FindUserByEmailUsertable.templ"));
+
     public FindUserByEmailPage() {
         super("Find Email");
     }
 
     @Override
     public void doGet(HttpServletRequest req, HttpServletResponse resp) throws IOException {
-        HashMap<String, Object> vars = new HashMap<String, Object>();
-        vars.put("first", true);
-        new FindUserByEmailForm(req).output(resp.getWriter(), Page.getLanguage(req), vars);
+        new FindUserByEmailForm(req).output(resp.getWriter(), Page.getLanguage(req), new HashMap<String, Object>());
     }
 
     @Override
@@ -40,7 +41,6 @@ public class FindUserByEmailPage extends Page {
                 resp.sendRedirect(SupportUserDetailsPage.PATH + emails[0].getOwner().getId() + "/");
             } else {
                 HashMap<String, Object> vars = new HashMap<String, Object>();
-                vars.put("first", false);
                 vars.put("usertable", new IterableDataset() {
 
                     int i = 0;
@@ -56,11 +56,11 @@ public class FindUserByEmailPage extends Page {
                         return true;
                     }
                 });
-                form.output(resp.getWriter(), getLanguage(req), vars);
+                USERTABLE.output(resp.getWriter(), getLanguage(req), vars);
             }
         } catch (GigiApiException e) {
             e.format(resp.getWriter(), Page.getLanguage(req));
-            doGet(req, resp);
+            form.output(resp.getWriter(), Page.getLanguage(req), new HashMap<String, Object>());
         }
     }
 
diff --git a/src/org/cacert/gigi/pages/admin/support/FindUserByEmailUsertable.templ b/src/org/cacert/gigi/pages/admin/support/FindUserByEmailUsertable.templ
new file mode 100644
index 00000000..0104a917
--- /dev/null
+++ b/src/org/cacert/gigi/pages/admin/support/FindUserByEmailUsertable.templ
@@ -0,0 +1,8 @@
+<p>Multiple users where found.</p>
+<table class="table">
+<tr>
+<th>Id</th><th>E-Mail</th></tr>
+<? foreach($usertable) {?>
+	<tr><td><a href="/support/user/<?=$usrid?>/"><?=$usrid?></a></td><td><a href="/support/user/<?=$usrid?>/"><?=$usermail?></a></td></tr>
+<? } ?>
+</table>
-- 
2.39.2