From: Lucas Werkmeister <mail@lucaswerkmeister.de>
Date: Tue, 28 Mar 2017 10:20:13 +0000 (+0200)
Subject: fix: put blanks between name components
X-Git-Url: https://code.wpia.club/?p=gigi.git;a=commitdiff_plain;h=b62c00db0226d58e5908b55463bbd9fda31b3fb4

fix: put blanks between name components

The previous commit attempted to fix

     Welcome back, Felix Dörre !

but instead produced

     Welcome back, FelixDörre!

Clearly, while we don’t want spaces around the full name, there should
be spaces in between the individual name parts.

Change-Id: I498ea9a0fdaf0f5b3191a3fc3cc47d0a3187b4f5
---

diff --git a/src/club/wpia/gigi/dbObjects/Name.java b/src/club/wpia/gigi/dbObjects/Name.java
index da7e7190..d5bff5cb 100644
--- a/src/club/wpia/gigi/dbObjects/Name.java
+++ b/src/club/wpia/gigi/dbObjects/Name.java
@@ -187,17 +187,20 @@ public class Name implements Outputable, IdCachable {
 
         @Override
         public void output(PrintWriter out) {
-            outputNameParts(out, "fname", firstNames);
-            outputNameParts(out, "lname", lastNames);
-            outputNameParts(out, "suffix", suffixes);
+            outputNameParts(out, "fname", firstNames, false);
+            outputNameParts(out, "lname", lastNames, true);
+            outputNameParts(out, "suffix", suffixes, true);
         }
 
-        private void outputNameParts(PrintWriter out, String type, NamePart[] input) {
+        private void outputNameParts(PrintWriter out, String type, NamePart[] input, boolean leadingSpace) {
             StringBuilder res;
             res = new StringBuilder();
             appendArray(res, input);
             if (res.length() > 0) {
                 res.deleteCharAt(res.length() - 1);
+                if (leadingSpace) {
+                    out.print(" ");
+                }
                 out.print("<span class='" + type + "'>");
                 out.print(HTMLEncoder.encodeHTML(res.toString()));
                 out.print("</span>");