From: Janis Streib <janis@dogcraft.de>
Date: Tue, 9 Sep 2014 10:27:37 +0000 (+0200)
Subject: FIX: Make fields private where possible
X-Git-Url: https://code.wpia.club/?p=gigi.git;a=commitdiff_plain;h=0fcce31dee5661974d5e8d19b33d1844c9651dca

FIX: Make fields private where possible
---

diff --git a/src/org/cacert/gigi/dbObjects/Domain.java b/src/org/cacert/gigi/dbObjects/Domain.java
index b481e76f..eb63b30b 100644
--- a/src/org/cacert/gigi/dbObjects/Domain.java
+++ b/src/org/cacert/gigi/dbObjects/Domain.java
@@ -15,15 +15,15 @@ public class Domain implements IdCachable {
 
     public class DomainPingExecution {
 
-        String state;
+        private String state;
 
-        String type;
+        private String type;
 
-        String info;
+        private String info;
 
-        String result;
+        private String result;
 
-        DomainPingConfiguration config;
+        private DomainPingConfiguration config;
 
         public DomainPingExecution(ResultSet rs) throws SQLException {
             state = rs.getString(1);
@@ -134,6 +134,7 @@ public class Domain implements IdCachable {
         return owner;
     }
 
+    @Override
     public int getId() {
         return id;
     }
diff --git a/src/org/cacert/gigi/dbObjects/DomainPingConfiguration.java b/src/org/cacert/gigi/dbObjects/DomainPingConfiguration.java
index a031b9e4..66805abe 100644
--- a/src/org/cacert/gigi/dbObjects/DomainPingConfiguration.java
+++ b/src/org/cacert/gigi/dbObjects/DomainPingConfiguration.java
@@ -12,13 +12,13 @@ public class DomainPingConfiguration implements IdCachable {
         EMAIL, DNS, HTTP, SSL;
     }
 
-    int id;
+    private int id;
 
-    Domain target;
+    private Domain target;
 
-    PingType type;
+    private PingType type;
 
-    String info;
+    private String info;
 
     private DomainPingConfiguration(int id) throws SQLException {
         PreparedStatement ps = DatabaseConnection.getInstance().prepare("SELECT id, domainid, type, info FROM pingconfig WHERE id=?");
diff --git a/src/org/cacert/gigi/dbObjects/ObjectCache.java b/src/org/cacert/gigi/dbObjects/ObjectCache.java
index 2a5d297b..1d239757 100644
--- a/src/org/cacert/gigi/dbObjects/ObjectCache.java
+++ b/src/org/cacert/gigi/dbObjects/ObjectCache.java
@@ -6,7 +6,7 @@ import java.util.HashSet;
 
 public class ObjectCache<T extends IdCachable> {
 
-    HashMap<Integer, WeakReference<T>> hashmap = new HashMap<>();
+    private HashMap<Integer, WeakReference<T>> hashmap = new HashMap<>();
 
     private static HashSet<ObjectCache<?>> caches = new HashSet<>();