From: Felix Dörre Date: Mon, 2 Nov 2015 03:10:55 +0000 (+0100) Subject: add: 2 simple tests + simple "certificate"-code cleanup X-Git-Url: https://code.wpia.club/?p=gigi.git;a=commitdiff_plain;h=038e2158a52d69c5cb4135f28f543e94d5e5ac47 add: 2 simple tests + simple "certificate"-code cleanup --- diff --git a/src/org/cacert/gigi/dbObjects/Certificate.java b/src/org/cacert/gigi/dbObjects/Certificate.java index 7318ad80..7dabe8cc 100644 --- a/src/org/cacert/gigi/dbObjects/Certificate.java +++ b/src/org/cacert/gigi/dbObjects/Certificate.java @@ -238,9 +238,6 @@ public class Certificate implements IdCachable { } public synchronized CertificateStatus getStatus() { - if (id == 0) { - return CertificateStatus.DRAFT; - } GigiPreparedStatement searcher = DatabaseConnection.getInstance().prepare("SELECT crt_name, created, revoked, serial, caid FROM certs WHERE id=?"); searcher.setInt(1, id); GigiResultSet rs = searcher.executeQuery(); diff --git a/tests/org/cacert/gigi/TestUser.java b/tests/org/cacert/gigi/TestUser.java index edee51f0..9fd1fe7a 100644 --- a/tests/org/cacert/gigi/TestUser.java +++ b/tests/org/cacert/gigi/TestUser.java @@ -114,4 +114,19 @@ public class TestUser extends ManagedTest { assertSame(u, emailUser); } + @Test + public void testNoCats() { + String email = createUniqueName() + "a@email.org"; + int id = createVerifiedUser("aä", "b", email, TEST_PASSWORD); + User emailUser = User.getByEmail(email); + assertFalse(emailUser.hasPassedCATS()); + } + + @Test + public void testGetByMailFail() { + String email = createUniqueName() + "d@email.org"; + User emailUser = User.getByEmail(email); + assertNull(emailUser); + } + }