]> WPIA git - gigi.git/commitdiff
Merge branch 'csrParse'
authorFelix Dörre <felix@dogcraft.de>
Tue, 12 Aug 2014 22:45:38 +0000 (00:45 +0200)
committerFelix Dörre <felix@dogcraft.de>
Tue, 12 Aug 2014 22:45:38 +0000 (00:45 +0200)
13 files changed:
src/org/cacert/gigi/Certificate.java
src/org/cacert/gigi/output/CertificateIterable.java
src/org/cacert/gigi/output/CertificateTable.templ
src/org/cacert/gigi/output/Form.java
src/org/cacert/gigi/output/template/OutputVariableCommand.java
src/org/cacert/gigi/pages/account/CertificateIssueForm.java
src/org/cacert/gigi/pages/account/CertificateIssueForm.templ
src/org/cacert/gigi/pages/account/RequestCertificate.templ
src/org/cacert/gigi/pages/main/Signup.java
src/org/cacert/gigi/pages/wot/AssuranceForm.java
tests/org/cacert/gigi/pages/main/RegisterPageTest.java
tests/org/cacert/gigi/pages/wot/TestAssurance.java
tests/org/cacert/gigi/testUtils/ManagedTest.java

index f06247cfda90c1ca7628fade6e6b3d841b716cfc..433e60e49b62a5bc6a97444d3ff7f1c104622c59 100644 (file)
@@ -38,7 +38,7 @@ public class Certificate {
         }
     }
 
-    public static class SubjectAlternateName {
+    public static class SubjectAlternateName implements Comparable<SubjectAlternateName> {
 
         private SANType type;
 
@@ -57,6 +57,49 @@ public class Certificate {
             return type;
         }
 
+        @Override
+        public int compareTo(SubjectAlternateName o) {
+            int i = type.compareTo(o.type);
+            if (i != 0) {
+                return i;
+            }
+            return name.compareTo(o.name);
+        }
+
+        @Override
+        public int hashCode() {
+            final int prime = 31;
+            int result = 1;
+            result = prime * result + ((name == null) ? 0 : name.hashCode());
+            result = prime * result + ((type == null) ? 0 : type.hashCode());
+            return result;
+        }
+
+        @Override
+        public boolean equals(Object obj) {
+            if (this == obj) {
+                return true;
+            }
+            if (obj == null) {
+                return false;
+            }
+            if (getClass() != obj.getClass()) {
+                return false;
+            }
+            SubjectAlternateName other = (SubjectAlternateName) obj;
+            if (name == null) {
+                if (other.name != null) {
+                    return false;
+                }
+            } else if ( !name.equals(other.name)) {
+                return false;
+            }
+            if (type != other.type) {
+                return false;
+            }
+            return true;
+        }
+
     }
 
     public enum CSRType {
index 11c4a507ec2bd0c95792b97c71b3b436931dc6ff..62e7f7057541a474389960c3028d357260156cf1 100644 (file)
@@ -32,6 +32,7 @@ public class CertificateIterable implements IterableDataset {
         vars.put("CN", c.getDistinguishedName());
         vars.put("serial", c.getSerial());
         vars.put("digest", c.getMessageDigest());
+        vars.put("profile", c.getProfile().getVisibleName());
 
         vars.put("issued", "TODO"); // TODO output dates
         vars.put("revoked", "TODO");
index f2870bba29899795fbbf2f9b364e3b1b904abb9a..29c53eb0f47359b76f6a6c0ad5e882902fcc52cd 100644 (file)
@@ -6,6 +6,7 @@
 <td><?=_Email Address?></td>
 <td><?=_SerialNumber?></td>
 <td><?=_Digest?></td>
+<td><?=_Profile?></td>
 <td><?=_Issued?></td>
 <td><?=_Revoked?></td>
 <td><?=_Expires?></td>
@@ -19,6 +20,7 @@
        <td><?=$CN?></td>
        <td><a href='/account/certs/<?=$serial?>'><?=$serial?></a></td>
        <td><?=$digest?></td>
+       <td><?=$profile?></td>
        <td><?=$issued?></td>
        <td><?=$revoked?></td>
        <td><?=$expire?></td>
index 176c7046995a57147b5066a85f45cc1f577b5b26..a4c65a488c70310b311627247e0484df22c9c362 100644 (file)
@@ -34,6 +34,7 @@ public abstract class Form implements Outputable {
     @Override
     public void output(PrintWriter out, Language l, Map<String, Object> vars) {
         out.println("<form method='POST' autocomplete='off'>");
+        failed = false;
         outputContent(out, l, vars);
         out.print("<input type='hidden' name='" + CSRF_FIELD + "' value='");
         out.print(getCSRFToken());
@@ -42,12 +43,39 @@ public abstract class Form implements Outputable {
 
     protected abstract void outputContent(PrintWriter out, Language l, Map<String, Object> vars);
 
-    protected void outputError(PrintWriter out, ServletRequest req, String text) {
+    boolean failed;
+
+    protected void outputError(PrintWriter out, ServletRequest req, String text, Object... contents) {
+        if ( !failed) {
+            failed = true;
+            out.println("<div class='formError'>");
+        }
         out.print("<div>");
-        out.print(Page.translate(req, text));
+        if (contents.length == 0) {
+            out.print(Page.translate(req, text));
+        } else {
+            out.print(String.format(Page.translate(req, text), contents));
+        }
         out.println("</div>");
     }
 
+    protected void outputErrorPlain(PrintWriter out, String text) {
+        if ( !failed) {
+            failed = true;
+            out.println("<div class='formError'>");
+        }
+        out.print("<div>");
+        out.print(text);
+        out.println("</div>");
+    }
+
+    public boolean isFailed(PrintWriter out) {
+        if (failed) {
+            out.println("</div>");
+        }
+        return failed;
+    }
+
     protected String getCSRFToken() {
         return csrf;
     }
index 382d0597ddd5991a40961c72f3a00eb1219496aa..1a304d894b39a5a6b532177796e1282b93b49be2 100644 (file)
@@ -10,20 +10,20 @@ public final class OutputVariableCommand implements Outputable {
 
     private final String raw;
 
-    private final boolean escaped;
+    private final boolean unescaped;
 
     public OutputVariableCommand(String raw) {
         if (raw.charAt(0) == '!') {
-            escaped = true;
+            unescaped = true;
             this.raw = raw.substring(1);
         } else {
-            escaped = true;
+            unescaped = false;
             this.raw = raw;
         }
     }
 
     @Override
     public void output(PrintWriter out, Language l, Map<String, Object> vars) {
-        Template.outputVar(out, l, vars, raw, escaped);
+        Template.outputVar(out, l, vars, raw, unescaped);
     }
 }
index 847aac88caeac6bae89fd09d2d79adabeb28a2be..decda34dfc074f417b8d84df63dd007e5816886e 100644 (file)
@@ -10,15 +10,19 @@ import java.security.interfaces.RSAPublicKey;
 import java.sql.SQLException;
 import java.util.Base64;
 import java.util.HashMap;
+import java.util.LinkedHashSet;
 import java.util.Map;
+import java.util.Set;
+import java.util.TreeSet;
 
 import javax.servlet.http.HttpServletRequest;
 
 import org.cacert.gigi.Certificate;
 import org.cacert.gigi.Certificate.CSRType;
+import org.cacert.gigi.Certificate.SANType;
+import org.cacert.gigi.Certificate.SubjectAlternateName;
 import org.cacert.gigi.CertificateProfile;
 import org.cacert.gigi.Digest;
-import org.cacert.gigi.EmailAddress;
 import org.cacert.gigi.GigiApiException;
 import org.cacert.gigi.User;
 import org.cacert.gigi.crypto.SPKAC;
@@ -32,10 +36,25 @@ import org.cacert.gigi.pages.Page;
 import org.cacert.gigi.util.PEM;
 import org.cacert.gigi.util.RandomToken;
 
+import sun.security.pkcs.PKCS9Attribute;
 import sun.security.pkcs10.PKCS10;
+import sun.security.pkcs10.PKCS10Attribute;
+import sun.security.pkcs10.PKCS10Attributes;
 import sun.security.util.DerInputStream;
 import sun.security.util.DerValue;
+import sun.security.x509.AVA;
 import sun.security.x509.AlgorithmId;
+import sun.security.x509.CertificateExtensions;
+import sun.security.x509.DNSName;
+import sun.security.x509.ExtendedKeyUsageExtension;
+import sun.security.x509.Extension;
+import sun.security.x509.GeneralName;
+import sun.security.x509.GeneralNameInterface;
+import sun.security.x509.GeneralNames;
+import sun.security.x509.RDN;
+import sun.security.x509.RFC822Name;
+import sun.security.x509.SubjectAlternativeNameExtension;
+import sun.security.x509.X500Name;
 
 /**
  * This class represents a form that is used for issuing certificates. This
@@ -43,20 +62,30 @@ import sun.security.x509.AlgorithmId;
  */
 public class CertificateIssueForm extends Form {
 
-    User u;
+    private static final String DEFAULT_CN = "CAcert WoT User";
 
-    Digest selectedDigest = Digest.getDefault();
+    private final static Template t = new Template(CertificateIssueForm.class.getResource("CertificateIssueForm.templ"));
 
-    boolean login;
+    private final static Template tIni = new Template(CertificateAdd.class.getResource("RequestCertificate.templ"));
 
-    String csr;
+    User u;
 
-    private final static Template t = new Template(CertificateIssueForm.class.getResource("CertificateIssueForm.templ"));
+    private CSRType csrType;
 
-    private final static Template tIni = new Template(CertificateAdd.class.getResource("RequestCertificate.templ"));
+    String csr;
 
     String spkacChallenge;
 
+    public String CN = DEFAULT_CN;
+
+    Set<SubjectAlternateName> SANs = new LinkedHashSet<>();
+
+    Digest selectedDigest = Digest.getDefault();
+
+    boolean login;
+
+    CertificateProfile profile = CertificateProfile.getById(1);
+
     public CertificateIssueForm(HttpServletRequest hsr) {
         super(hsr);
         u = Page.getUser(hsr);
@@ -65,8 +94,6 @@ public class CertificateIssueForm extends Form {
 
     Certificate result;
 
-    private CSRType csrType;
-
     public Certificate getResult() {
         return result;
     }
@@ -80,9 +107,65 @@ public class CertificateIssueForm extends Form {
                 if (csr != null) {
                     byte[] data = PEM.decode("(NEW )?CERTIFICATE REQUEST", csr);
                     PKCS10 parsed = new PKCS10(data);
+                    PKCS10Attributes atts = parsed.getAttributes();
+
+                    for (PKCS10Attribute b : atts.getAttributes()) {
+
+                        if ( !b.getAttributeId().equals((Object) PKCS9Attribute.EXTENSION_REQUEST_OID)) {
+                            // unknown attrib
+                            continue;
+                        }
+
+                        for (RDN r : parsed.getSubjectName().rdns()) {
+                            for (AVA a : r.avas()) {
+                                if (a.getObjectIdentifier().equals((Object) PKCS9Attribute.EMAIL_ADDRESS_OID)) {
+                                    SANs.add(new SubjectAlternateName(SANType.EMAIL, a.getValueString()));
+                                } else if (a.getObjectIdentifier().equals((Object) X500Name.commonName_oid)) {
+                                    CN = a.getValueString();
+                                }
+                            }
+                        }
+
+                        for (Extension c : ((CertificateExtensions) b.getAttributeValue()).getAllExtensions()) {
+                            if (c instanceof SubjectAlternativeNameExtension) {
+
+                                SubjectAlternativeNameExtension san = (SubjectAlternativeNameExtension) c;
+                                GeneralNames obj = san.get(SubjectAlternativeNameExtension.SUBJECT_NAME);
+                                for (int i = 0; i < obj.size(); i++) {
+                                    GeneralName generalName = obj.get(i);
+                                    GeneralNameInterface peeled = generalName.getName();
+                                    if (peeled instanceof DNSName) {
+                                        SANs.add(new SubjectAlternateName(SANType.DNS, ((DNSName) peeled).getName()));
+                                    } else if (peeled instanceof RFC822Name) {
+                                        SANs.add(new SubjectAlternateName(SANType.EMAIL, ((RFC822Name) peeled).getName()));
+                                    }
+                                }
+                            } else if (c instanceof ExtendedKeyUsageExtension) {
+                                ExtendedKeyUsageExtension ekue = (ExtendedKeyUsageExtension) c;
+                                for (String s : ekue.getExtendedKeyUsage()) {
+                                    if (s.equals("1.3.6.1.5.5.7.3.1")) {
+                                        // server
+                                    } else if (s.equals("1.3.6.1.5.5.7.3.2")) {
+                                        // client
+                                    } else if (s.equals("1.3.6.1.5.5.7.3.3")) {
+                                        // code sign
+                                    } else if (s.equals("1.3.6.1.5.5.7.3.4")) {
+                                        // emailProtection
+                                    } else if (s.equals("1.3.6.1.5.5.7.3.8")) {
+                                        // timestamp
+                                    } else if (s.equals("1.3.6.1.5.5.7.3.9")) {
+                                        // OCSP
+                                    }
+                                }
+                            } else {
+                                // Unknown requested extension
+                            }
+                        }
 
+                    }
                     out.println(parsed.getSubjectName().getCommonName());
                     out.println(parsed.getSubjectName().getCountry());
+
                     out.println("CSR DN: " + parsed.getSubjectName() + "<br/>");
                     PublicKey pk = parsed.getSubjectPublicKeyInfo();
                     checkKeyStrength(pk, out);
@@ -108,26 +191,82 @@ public class CertificateIssueForm extends Form {
 
                 } else {
                     login = "1".equals(req.getParameter("login"));
+                    CN = req.getParameter("CN");
                     String hashAlg = req.getParameter("hash_alg");
                     if (hashAlg != null) {
                         selectedDigest = Digest.valueOf(hashAlg);
                     }
+                    profile = CertificateProfile.getByName(req.getParameter("profile"));
+
+                    String pDNS = null;
+                    String pMail = null;
+                    Set<SubjectAlternateName> filteredSANs = new LinkedHashSet<>();
+                    boolean server = profile.getKeyName().equals("server");
+                    for (SubjectAlternateName san : parseSANBox(req.getParameter("SANs"))) {
+                        if (san.getType() == SANType.DNS) {
+                            if (u.isValidDomain(san.getName()) && server) {
+                                if (pDNS == null) {
+                                    pDNS = san.getName();
+                                }
+                                filteredSANs.add(san);
+                                continue;
+                            }
+                        } else if (san.getType() == SANType.EMAIL) {
+                            if (u.isValidEmail(san.getName()) && !server) {
+                                if (pMail == null) {
+                                    pMail = san.getName();
+                                }
+                                filteredSANs.add(san);
+                                continue;
+                            }
+                        }
+                        outputError(out, req, "The requested Subject alternate name \"%s\" has been removed.",//
+                                san.getType().toString().toLowerCase() + ":" + san.getName());
+                    }
+                    SANs = filteredSANs;
+                    if ( !u.isValidName(CN) && !server && !CN.equals(DEFAULT_CN)) {
+                        CN = DEFAULT_CN;
+                        outputError(out, req, "The real name entered cannot be verified with your account.");
+                    }
+
+                    final StringBuffer subject = new StringBuffer();
+                    if (server && pDNS != null) {
+                        subject.append("/commonName=");
+                        subject.append(pDNS);
+                        if (pMail != null) {
+                            outputError(out, req, "No email is included in this certificate.");
+                        }
+                        if (CN.equals("")) {
+                            CN = "";
+                            outputError(out, req, "No real name is included in this certificate.");
+                        }
+                    } else {
+                        subject.append("/commonName=");
+                        subject.append(CN);
+                        if (pMail != null) {
+                            subject.append("/emailAddress=");
+                            subject.append(pMail);
+                        }
+                    }
                     if (req.getParameter("CCA") == null) {
                         outputError(out, req, "You need to accept the CCA.");
+                    }
+                    if (isFailed(out)) {
                         return false;
                     }
-                    CertificateProfile profile = CertificateProfile.getByName(req.getParameter("profile"));
 
-                    System.out.println("issuing " + selectedDigest);
-                    result = new Certificate(LoginPage.getUser(req).getId(), "/commonName=CAcert WoT User", selectedDigest.toString(), this.csr, this.csrType, profile);
+                    result = new Certificate(LoginPage.getUser(req).getId(), subject.toString(), selectedDigest.toString(), //
+                            this.csr, this.csrType, profile, SANs.toArray(new SubjectAlternateName[SANs.size()]));
                     result.issue().waitFor(60000);
                     return true;
                 }
             } catch (IOException e) {
                 e.printStackTrace();
             } catch (IllegalArgumentException e) {
+                e.printStackTrace();
                 throw new GigiApiException("Certificate Request format is invalid.");
             } catch (GeneralSecurityException e) {
+                e.printStackTrace();
                 throw new GigiApiException("Certificate Request format is invalid.");
             } catch (InterruptedException e) {
                 e.printStackTrace();
@@ -140,6 +279,36 @@ public class CertificateIssueForm extends Form {
         return false;
     }
 
+    private TreeSet<SubjectAlternateName> parseSANBox(String SANs) {
+        String[] SANparts = SANs.split("[\r\n]+|, *");
+        TreeSet<SubjectAlternateName> parsedNames = new TreeSet<>();
+        for (String SANline : SANparts) {
+            String[] parts = SANline.split(":", 2);
+            if (parts.length == 1) {
+                if (parts[0].trim().equals("")) {
+                    continue;
+                }
+                if (parts[0].contains("@")) {
+                    parsedNames.add(new SubjectAlternateName(SANType.EMAIL, parts[0]));
+                } else {
+                    parsedNames.add(new SubjectAlternateName(SANType.DNS, parts[0]));
+                }
+                continue;
+            }
+            try {
+                SANType t = Certificate.SANType.valueOf(parts[0].toUpperCase());
+                if (t == null) {
+                    continue;
+                }
+                parsedNames.add(new SubjectAlternateName(t, parts[1]));
+            } catch (IllegalArgumentException e) {
+                // invalid enum type
+                continue;
+            }
+        }
+        return parsedNames;
+    }
+
     private void checkKeyStrength(PublicKey pk, PrintWriter out) {
         out.println("Type: " + pk.getAlgorithm() + "<br/>");
         if (pk instanceof RSAPublicKey) {
@@ -157,10 +326,6 @@ public class CertificateIssueForm extends Form {
         }
     }
 
-    private static PKCS10 parseCSR(String csr) throws IOException, GeneralSecurityException {
-        return new PKCS10(PEM.decode("(NEW )?CERTIFICATE REQUEST", csr));
-    }
-
     private static String getSignatureAlgorithm(byte[] data) throws IOException {
         DerInputStream in = new DerInputStream(data);
         DerValue[] seq = in.getSequence(3);
@@ -186,22 +351,16 @@ public class CertificateIssueForm extends Form {
         HashMap<String, Object> vars2 = new HashMap<String, Object>(vars);
         vars2.put("CCA", "<a href='/policy/CAcertCommunityAgreement.html'>CCA</a>");
 
-        final EmailAddress[] ea = u.getEmails();
-        vars2.put("emails", new IterableDataset() {
-
-            int count;
+        StringBuffer content = new StringBuffer();
+        for (SubjectAlternateName SAN : SANs) {
+            content.append(SAN.getType().toString().toLowerCase());
+            content.append(':');
+            content.append(SAN.getName());
+            content.append('\n');
+        }
 
-            @Override
-            public boolean next(Language l, Map<String, Object> vars) {
-                if (count >= ea.length) {
-                    return false;
-                }
-                vars.put("id", ea[count].getId());
-                vars.put("value", ea[count].getAddress());
-                count++;
-                return true;
-            }
-        });
+        vars2.put("CN", CN);
+        vars2.put("emails", content.toString());
         vars2.put("hashs", new HashAlgorithms(selectedDigest));
         vars2.put("profiles", new IterableDataset() {
 
@@ -213,6 +372,11 @@ public class CertificateIssueForm extends Form {
                 if (cp == null) {
                     return false;
                 }
+                if (cp.getId() == profile.getId()) {
+                    vars.put("selected", " selected");
+                } else {
+                    vars.put("selected", "");
+                }
                 vars.put("key", cp.getKeyName());
                 vars.put("name", cp.getVisibleName());
                 return true;
index 55eb1219f0360dd1b5f612f8cb3ede2212e04676..6c76287cce89397519d1b15486a8adc242f97ffa 100644 (file)
     <?=_Key type?>: 
     <select name="profile">
     <? foreach($profiles) { ?>
-      <option value="<?=$key?>"><?=$name?></option>
+      <option value="<?=$key?>"<?=$!selected?>><?=$name?></option>
     <? } ?>
     </select>
     </td>
   </tr>
   <tr>
-    <td><?=_Add?></td>
-    <td><?=_Address?></td>
+    <td><?=_Your name?></td>
+    <td><input type='text' name='CN' value='<?=$CN?>'></td>
   </tr>
-<? foreach($emails) { ?>
   <tr>
-    <td><input type="checkbox" id="addid<?=$id?>" name="addid[]" value="<?=$id?>"></td>
-    <td align="left"><label for="addid<?=$id?>"><?=$value?></label></td>
+    <td>SANs</td>
+    <td align="left"><textarea rows='5' name='SANs' placeholder="dns:my.domain.example.com, dns:*.example.com, email:my.email@example.com (or newline separated)"><?=$emails?></textarea></td>
   </tr>
-<? } ?>
 
 <? if($points50) { ?>
   <tr>
   </tr>
 <? } ?>
 
-  <tr>
-    <td>
-      <input type="checkbox" id="login" name="login" value="1" checked="checked" />
-    </td>
-    <td align="left">
-      <label for="login"><?=_Enable certificate login with this certificate?><br />
-      <?=_By allowing certificate login, this certificate can be used to login into this account at https://secure.cacert.org/ .?></label>
-    </td>
-  </tr>
-  <tr>
-    <td colspan="2" align="left">
-      <label for="description"><?=_Optional comment, only used in the certificate overview?></label><br />
-      <input type="text" id="description" name="description" maxlength="100" size="100" />
-    </td>
-  </tr>
 
   <tr class="expertoff">
     <td>
       <? } ?>
     </td>
   </tr>
+  <tr><td colspan='2'>&nbsp;</td></tr>
+  <tr>
+    <td>
+      <input type="checkbox" id="login" name="login" value="1" checked="checked" />
+    </td>
+    <td align="left">
+      <label for="login"><?=_Enable certificate login with this certificate?><br />
+      <?=_By allowing certificate login, this certificate can be used to login into this account at https://secure.cacert.org/ .?></label>
+    </td>
+  </tr>
+  <tr>
+    <td colspan="2" align="left">
+      <label for="description"><?=_Optional comment, only used in the certificate overview?></label><br />
+      <input type="text" id="description" name="description" maxlength="100" size="100" />
+    </td>
+  </tr>
 
   <tr>
     <td>
index d41a60a555e8dd2dc012cec8ced62fcd88d9cf46..a0f49dd7280b46f20df689b8106a0d79ded21c4c 100644 (file)
@@ -7,8 +7,8 @@
   </thead>
   <tbody>
   <tr>
-    <td><?=_CSR?></td>
-    <td><?=_SPKAC?></td>
+    <td><?=_I have a CSR! Paste it here:?></td>
+    <td><?=_I do not have a CSR.?></td>
   </tr>
 
   <tr>
index e956aa436eb59b4597ea62413dc5973a6187d348..c9b77f6125c71d2ecb178eb9d275031bae672af9 100644 (file)
@@ -89,40 +89,30 @@ public class Signup extends Form {
     @Override
     public synchronized boolean submit(PrintWriter out, HttpServletRequest req) {
         update(req);
-        boolean failed = false;
-        out.println("<div class='formError'>");
         if (buildup.getFname().equals("") || buildup.getLname().equals("")) {
             outputError(out, req, "First and/or last names were blank.");
-            failed = true;
         }
         if ( !myDoB.isValid()) {
             outputError(out, req, "Invalid date of birth");
-            failed = true;
         }
         if ( !"1".equals(req.getParameter("cca_agree"))) {
             outputError(out, req, "You have to agree to the CAcert Community agreement.");
-            failed = true;
         }
         if (buildup.getEmail().equals("")) {
             outputError(out, req, "Email Address was blank");
-            failed = true;
         }
         String pw1 = req.getParameter("pword1");
         String pw2 = req.getParameter("pword2");
         if (pw1 == null || pw1.equals("")) {
             outputError(out, req, "Pass Phrases were blank");
-            failed = true;
         } else if ( !pw1.equals(pw2)) {
             outputError(out, req, "Pass Phrases don't match");
-            failed = true;
         }
         int pwpoints = PasswordStrengthChecker.checkpw(pw1, buildup);
         if (pwpoints < 3) {
             outputError(out, req, "The Pass Phrase you submitted failed to contain enough" + " differing characters and/or contained words from" + " your name and/or email address.");
-            failed = true;
         }
-        if (failed) {
-            out.println("</div>");
+        if (isFailed(out)) {
             return false;
         }
         try {
@@ -134,7 +124,6 @@ public class Signup extends Form {
             ResultSet r2 = q2.executeQuery();
             if (r1.next() || r2.next()) {
                 outputError(out, req, "This email address is currently valid in the system.");
-                failed = true;
             }
             r1.close();
             r2.close();
@@ -144,15 +133,12 @@ public class Signup extends Form {
             ResultSet r3 = q3.executeQuery();
             if (r3.next()) {
                 String domain = r3.getString(1);
-                out.print("<div>");
-                out.print(String.format(Page.translate(req, "We don't allow signups from people using email addresses from %s"), domain));
-                out.println("</div>");
-                failed = true;
+                outputError(out, req, "We don't allow signups from people using email addresses from %s", domain);
             }
             r3.close();
         } catch (SQLException e) {
             e.printStackTrace();
-            failed = true;
+            outputError(out, req, "an internal error happened");
         }
         String mailResult = EmailProvider.FAIL;
         try {
@@ -168,15 +154,11 @@ public class Signup extends Form {
             if (mailResult.equals(EmailProvider.FAIL)) {
                 outputError(out, req, "Failed to make a connection to the mail server");
             } else {
-                out.print("<div>");
-                out.print(mailResult);
-                out.println("</div>");
+                outputErrorPlain(out, mailResult);
             }
-            failed = true;
         }
 
-        out.println("</div>");
-        if (failed) {
+        if (isFailed(out)) {
             return false;
         }
         try {
index 3d68716ec293670302669ed4181459b1b9ad5d56..e3dfe54c106f04b05b2635f259a092ac3c79a9d8 100644 (file)
@@ -50,45 +50,34 @@ public class AssuranceForm extends Form {
 
     @Override
     public boolean submit(PrintWriter out, HttpServletRequest req) {
-        out.println("<div class='formError'>");
-        boolean failed = false;
-
         if ( !"1".equals(req.getParameter("certify")) || !"1".equals(req.getParameter("rules")) || !"1".equals(req.getParameter("CCAAgreed")) || !"1".equals(req.getParameter("assertion"))) {
             outputError(out, req, "You failed to check all boxes to validate" + " your adherence to the rules and policies of CAcert");
-            failed = true;
 
         }
         if (req.getParameter("date") == null || req.getParameter("date").equals("")) {
             outputError(out, req, "You must enter the date when you met the assuree.");
-            failed = true;
         } else {
             try {
                 Date d = sdf.parse(req.getParameter("date"));
                 if (d.getTime() > System.currentTimeMillis()) {
                     outputError(out, req, "You must not enter a date in the future.");
-                    failed = true;
                 }
             } catch (ParseException e) {
                 outputError(out, req, "You must enter the date in this format: YYYY-MM-DD.");
-                failed = true;
             }
         }
         // check location, min 3 characters
         if (req.getParameter("location") == null || req.getParameter("location").equals("")) {
             outputError(out, req, "You failed to enter a location of your meeting.");
-            failed = true;
         } else if (req.getParameter("location").length() <= 2) {
             outputError(out, req, "You must enter a location with at least 3 characters eg town and country.");
-            failed = true;
         }
         // TODO checkPoints
         String points = req.getParameter("points");
         if (points == null || "".equals(points)) {
-            // TODO message
-            failed = true;
+            outputError(out, req, "For an assurance, you need to enter points.");
         }
-        if (failed) {
-            out.println("</div>");
+        if (isFailed(out)) {
             return false;
         }
         try {
@@ -96,13 +85,11 @@ public class AssuranceForm extends Form {
             if (success != AssuranceResult.ASSURANCE_SUCCEDED) {
                 outputError(out, req, success.getMessage());
             }
-            out.println("</div>");
             return success == AssuranceResult.ASSURANCE_SUCCEDED;
         } catch (SQLException e) {
             e.printStackTrace();
         }
 
-        out.println("</div>");
         return false;
     }
 
index be0124a7fd7c8100b7653dde090c02660c60d7cb..c21d7a263c84eaa29d87d4babb48ac9de781f272 100644 (file)
@@ -33,14 +33,14 @@ public class RegisterPageTest extends ManagedTest {
 
         String query = defaultSignup + URLEncoder.encode("correct3_" + uniq + "@email.de", "UTF-8") + "&general=1&country=1&regional=1&radius=1";
         String data = fetchStartErrorMessage(runRegister(query));
-        assertTrue(data, data.startsWith("</div>"));
+        assertNull(data);
         assertSuccessfullRegMail();
 
         getMailReciever().setEmailCheckError("400 Greylisted");
         getMailReciever().setApproveRegex(Pattern.compile("a"));
         query = defaultSignup + URLEncoder.encode("correct4_" + uniq + "@email.de", "UTF-8") + "&general=1&country=1&regional=1&radius=1";
         data = fetchStartErrorMessage(runRegister(query));
-        assertFalse(data, data.startsWith("</div>"));
+        assertNotNull(data);
 
         assertNull(getMailReciever().recieve());
 
index 94f194a3a7bd7aa1a330e30c1f67e8e4b86d6fd5..6e4d5ea26eb3928f92eda623088588ba227f54a5 100644 (file)
@@ -79,7 +79,7 @@ public class TestAssurance extends ManagedTest {
     @Test
     public void testAssureForm() throws IOException {
         String error = getError("date=2000-01-01&location=testcase&certify=1&rules=1&CCAAgreed=1&assertion=1&points=10");
-        assertTrue(error, error.startsWith("</div>"));
+        assertNull(error);
     }
 
     @Test
index 563017876efe509fcb558761cfac70cd885724d5..2d48a014869c6b79f54dab12367001bea63ef42a 100644 (file)
@@ -229,7 +229,7 @@ public class ManagedTest {
         try {
             String query = "fname=" + URLEncoder.encode(firstName, "UTF-8") + "&lname=" + URLEncoder.encode(lastName, "UTF-8") + "&email=" + URLEncoder.encode(email, "UTF-8") + "&pword1=" + URLEncoder.encode(password, "UTF-8") + "&pword2=" + URLEncoder.encode(password, "UTF-8") + "&day=1&month=1&year=1910&cca_agree=1";
             String data = fetchStartErrorMessage(runRegister(query));
-            assertTrue(data, data.startsWith("</div>"));
+            assertNull(data);
         } catch (UnsupportedEncodingException e) {
             throw new Error(e);
         } catch (IOException e) {
@@ -297,7 +297,7 @@ public class ManagedTest {
     static int count = 0;
 
     public static String createUniqueName() {
-        return "test" + System.currentTimeMillis() + "a" + (count++);
+        return "test" + System.currentTimeMillis() + "a" + (count++) + "u";
     }
 
     private String stripCookie(String headerField) {