FIX: Make fields private where possible

diff --git a/src/org/cacert/gigi/dbObjects/Domain.java b/src/org/cacert/gigi/dbObjects/Domain.java
index b481e76fe5868bb3c09a15616bdc2e6a22c95d4a..eb63b30b970283d6d0798d8f447a5326afa3ac65 100644 (file)
--- a/src/org/cacert/gigi/dbObjects/Domain.java
+++ b/src/org/cacert/gigi/dbObjects/Domain.java
@@ -15,15 +15,15 @@ public class Domain implements IdCachable {
 
     public class DomainPingExecution {
 
-        String state;
+        private String state;
 
-        String type;
+        private String type;
 
-        String info;
+        private String info;
 
-        String result;
+        private String result;
 
-        DomainPingConfiguration config;
+        private DomainPingConfiguration config;
 
         public DomainPingExecution(ResultSet rs) throws SQLException {
             state = rs.getString(1);
@@ -134,6 +134,7 @@ public class Domain implements IdCachable {
         return owner;
     }
 
+    @Override
     public int getId() {
         return id;
     }

diff --git a/src/org/cacert/gigi/dbObjects/DomainPingConfiguration.java b/src/org/cacert/gigi/dbObjects/DomainPingConfiguration.java
index a031b9e48f14b3b4e651966f22616d625ad8bfde..66805abeceacceceafb12b8ab7c55285184a5844 100644 (file)
--- a/src/org/cacert/gigi/dbObjects/DomainPingConfiguration.java
+++ b/src/org/cacert/gigi/dbObjects/DomainPingConfiguration.java
@@ -12,13 +12,13 @@ public class DomainPingConfiguration implements IdCachable {
         EMAIL, DNS, HTTP, SSL;
     }
 
-    int id;
+    private int id;
 
-    Domain target;
+    private Domain target;
 
-    PingType type;
+    private PingType type;
 
-    String info;
+    private String info;
 
     private DomainPingConfiguration(int id) throws SQLException {
         PreparedStatement ps = DatabaseConnection.getInstance().prepare("SELECT id, domainid, type, info FROM pingconfig WHERE id=?");

diff --git a/src/org/cacert/gigi/dbObjects/ObjectCache.java b/src/org/cacert/gigi/dbObjects/ObjectCache.java
index 2a5d297b96652d3c2b07cbd9fa402bb87297c361..1d239757fd0cb47b63140752cde16623c8e695ba 100644 (file)
--- a/src/org/cacert/gigi/dbObjects/ObjectCache.java
+++ b/src/org/cacert/gigi/dbObjects/ObjectCache.java
@@ -6,7 +6,7 @@ import java.util.HashSet;
 
 public class ObjectCache<T extends IdCachable> {
 
-    HashMap<Integer, WeakReference<T>> hashmap = new HashMap<>();
+    private HashMap<Integer, WeakReference<T>> hashmap = new HashMap<>();
 
     private static HashSet<ObjectCache<?>> caches = new HashSet<>();