String newLname = req.getParameter("lname").trim();
String newMname = req.getParameter("mname").trim();
String newSuffix = req.getParameter("suffix").trim();
- if (newFname.isEmpty() && !target.getFname().isEmpty()) {
- throw new GigiApiException("Names couldn't be removed.");
+ if (newLname.isEmpty()) {
+ throw new GigiApiException("Last name cannot be empty.");
}
target.setFname(newFname);
target.setLname(newLname);
@Override
public synchronized boolean submit(PrintWriter out, HttpServletRequest req) {
update(req);
- if (buildup.getFname().equals("") || buildup.getLname().equals("")) {
- outputError(out, req, "First and/or last names were blank.");
+ if (buildup.getLname().trim().equals("")) {
+ outputError(out, req, "Last name were blank.");
}
if ( !myDoB.isValid()) {
outputError(out, req, "Invalid date of birth");
@Test
public void testUnsetFname() throws IOException {
- assertNotNull(executeBasicWebInteraction(cookie, MyDetails.PATH, "fname=&lname=Hansel&mname=&suffix=&day=1&month=1&year=2000&processDetails", 0));
+ assertNull(executeBasicWebInteraction(cookie, MyDetails.PATH, "fname=&lname=Hansel&mname=&suffix=&day=1&month=1&year=2000&processDetails", 0));
User u = User.getById(id);
- assertEquals("Kurti", u.getFname());
+ assertEquals("", u.getFname());
}
@Test
public void testUnsetLname() throws IOException {
- assertNull(executeBasicWebInteraction(cookie, MyDetails.PATH, "lname=&fname=Kurti&mname=&suffix=&day=1&month=1&year=2000&processDetails", 0));
+ assertNotNull(executeBasicWebInteraction(cookie, MyDetails.PATH, "lname=&fname=Kurti&mname=&suffix=&day=1&month=1&year=2000&processDetails", 0));
User u = User.getById(id);
- assertEquals("", u.getLname());
+ assertEquals("Hansel", u.getLname());
}
@Test