upd: make verification processes more consistent on failure

[gigi.git] / src / org / cacert / gigi / pages / Verify.java

diff --git a/src/org/cacert/gigi/pages/Verify.java b/src/org/cacert/gigi/pages/Verify.java
index 2ebd54c5f2d4447ae9fe5a8352a05c53229c8300..2b4cd82605cfe2ffc62fa76b2cde50e489717ad0 100644 (file)
--- a/src/org/cacert/gigi/pages/Verify.java
+++ b/src/org/cacert/gigi/pages/Verify.java
@@ -2,6 +2,9 @@ package org.cacert.gigi.pages;
 
 import java.io.IOException;
 import java.io.PrintWriter;
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.Map;
 
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
@@ -9,9 +12,82 @@ import javax.servlet.http.HttpServletResponse;
 import org.cacert.gigi.GigiApiException;
 import org.cacert.gigi.dbObjects.Domain;
 import org.cacert.gigi.dbObjects.EmailAddress;
+import org.cacert.gigi.dbObjects.Verifyable;
+import org.cacert.gigi.localisation.Language;
+import org.cacert.gigi.output.template.Form;
+import org.cacert.gigi.output.template.Scope;
+import org.cacert.gigi.output.template.SprintfCommand;
 
 public class Verify extends Page {
 
+    private static final SprintfCommand emailAddressVerified = new SprintfCommand("Email address {0} verified", Arrays.asList("${subject}"));
+
+    private static final SprintfCommand domainVerified = new SprintfCommand("Domain {0} verified", Arrays.asList("${subject}"));
+
+    private class VerificationForm extends Form {
+
+        private String hash;
+
+        private String type;
+
+        private String id;
+
+        private Verifyable target;
+
+        String subject;
+
+        public VerificationForm(HttpServletRequest hsr) {
+            super(hsr, PATH);
+            hash = hsr.getParameter("hash");
+            type = hsr.getParameter("type");
+            id = hsr.getParameter("id");
+            if ("email".equals(type)) {
+                EmailAddress addr = EmailAddress.getById(Integer.parseInt(id));
+                subject = addr.getAddress();
+                target = addr;
+            } else if ("domain".equals(type)) {
+                Domain domain = Domain.getById(Integer.parseInt(id));
+                subject = domain.getSuffix();
+                target = domain;
+            } else {
+                throw new IllegalArgumentException();
+            }
+        }
+
+        @Override
+        public SubmissionResult submit(HttpServletRequest req) throws GigiApiException {
+            HashMap<String, Object> data = new HashMap<>();
+            data.put("subject", subject);
+            if ("email".equals(type)) {
+                try {
+                    target.verify(hash);
+                } catch (IllegalArgumentException e) {
+                    throw new PermamentFormException(new GigiApiException("Given token could not be found to complete the verification process (Email Ping)."));
+                }
+                return new SuccessMessageResult(new Scope(emailAddressVerified, data));
+            } else if ("domain".equals(type)) {
+                try {
+                    target.verify(hash);
+                } catch (IllegalArgumentException e) {
+                    throw new PermamentFormException(new GigiApiException("Given token could not be found to complete the verification process (Domain Ping)."));
+                }
+                return new SuccessMessageResult(new Scope(domainVerified, data));
+            } else {
+                throw new GigiApiException("Invalid object type.");
+            }
+        }
+
+        @Override
+        protected void outputContent(PrintWriter out, Language l, Map<String, Object> vars) {
+            vars.put("hash", hash);
+            vars.put("id", id);
+            vars.put("type", type);
+
+            vars.put("subject", subject);
+            getDefaultTemplate().output(out, l, vars);
+        }
+    }
+
     public static final String PATH = "/verify";
 
     public Verify() {
@@ -23,32 +99,24 @@ public class Verify extends Page {
         return false;
     }
 
+    @Override
+    public boolean beforePost(HttpServletRequest req, HttpServletResponse resp) throws IOException {
+        return Form.getForm(req, VerificationForm.class).submitExceptionProtected(req, resp);
+    }
+
+    @Override
+    public void doPost(HttpServletRequest req, HttpServletResponse resp) throws IOException {
+        if (Form.printFormErrors(req, resp.getWriter())) {
+            Form.getForm(req, VerificationForm.class).output(resp.getWriter(), getLanguage(req), new HashMap<String, Object>());
+        }
+    }
+
     @Override
     public void doGet(HttpServletRequest req, HttpServletResponse resp) throws IOException {
-        PrintWriter out = resp.getWriter();
-        String hash = req.getParameter("hash");
-        String type = req.getParameter("type");
-        String id = req.getParameter("id");
-        if ("email".equals(type)) {
-            try {
-                EmailAddress ea = EmailAddress.getById(Integer.parseInt(id));
-                ea.verify(hash);
-                out.println("Email verification completed.");
-            } catch (IllegalArgumentException e) {
-                out.println(translate(req, "The email address is invalid."));
-            } catch (GigiApiException e) {
-                e.format(out, getLanguage(req));
-            }
-        } else if ("domain".equals(type)) {
-            try {
-                Domain ea = Domain.getById(Integer.parseInt(id));
-                ea.verify(hash);
-                out.println("Domain verification completed.");
-            } catch (IllegalArgumentException e) {
-                out.println(translate(req, "The domain address is invalid."));
-            } catch (GigiApiException e) {
-                e.format(out, getLanguage(req));
-            }
+        try {
+            new VerificationForm(req).output(resp.getWriter(), getLanguage(req), new HashMap<String, Object>());
+        } catch (IllegalArgumentException e) {
+            resp.getWriter().println(translate(req, "The object to verify is invalid."));
         }
     }