From: Benny Baumann <BenBE1987@gmx.net>
Date: Mon, 6 Mar 2017 08:05:26 +0000 (+0100)
Subject: chg: Make the signer actively reject MD5 and SHA1
X-Git-Url: https://code.wpia.club/?a=commitdiff_plain;h=8c36452a1422eea1631cff4d90a3b801ed05cd77;hp=fd41b4a5253bd23236808bc324413be612f5ccca;p=cassiopeia.git

chg: Make the signer actively reject MD5 and SHA1

Change-Id: Icb4ca0df56e284944c6840b2cb4b0852fe7999a6
---

diff --git a/src/crypto/X509.cpp b/src/crypto/X509.cpp
index 37bb900..f9dbc7a 100644
--- a/src/crypto/X509.cpp
+++ b/src/crypto/X509.cpp
@@ -237,9 +237,11 @@ std::shared_ptr<SignedCertificate> X509Cert::sign( std::shared_ptr<EVP_PKEY> caK
     } else if( signAlg == "sha256" ) {
         md = EVP_sha256();
     } else if( signAlg == "sha1" ) {
-        md = EVP_sha1();
+        throw std::runtime_error("Refusing to sign with weak signature algorithm (SHA-1).");
+    } else if( signAlg == "md5" ) {
+        throw std::runtime_error("Refusing to sign with weak signature algorithm (MD5).");
     } else {
-        throw std::runtime_error("Unknown md-type");
+        throw std::runtime_error("Unknown signature algorithm");
     }
 
     if( !X509_sign( target.get(), caKey.get(), md ) ) {