From b373422ceb172e10e2ff32c09141158529b3f48b Mon Sep 17 00:00:00 2001 From: INOPIAE Date: Mon, 29 Jun 2020 10:27:05 +0200 Subject: [PATCH] fix: check if email is a valid pattern while account creation Change-Id: Ic859ea7cb02fcaebe7e26d9b141fd7d97e9c1122 --- src/club/wpia/gigi/pages/main/Signup.java | 5 +++++ tests/club/wpia/gigi/pages/main/RegisterPageTest.java | 3 +++ 2 files changed, 8 insertions(+) diff --git a/src/club/wpia/gigi/pages/main/Signup.java b/src/club/wpia/gigi/pages/main/Signup.java index 60d85be6..1c7942b5 100644 --- a/src/club/wpia/gigi/pages/main/Signup.java +++ b/src/club/wpia/gigi/pages/main/Signup.java @@ -141,6 +141,11 @@ public class Signup extends Form { throw gaPassword; } GigiApiException ga2 = new GigiApiException(); + + if ( !EmailProvider.isValidMailAddress(email)) { + ga2.mergeInto(new GigiApiException("This email address seems not to be valid.")); + } + try (GigiPreparedStatement q1 = new GigiPreparedStatement("SELECT * FROM `emails` WHERE `email`=? AND `deleted` IS NULL"); GigiPreparedStatement q2 = new GigiPreparedStatement("SELECT * FROM `certOwners` INNER JOIN `users` ON `users`.`id`=`certOwners`.`id` WHERE `email`=? AND `deleted` IS NULL")) { q1.setString(1, email); q2.setString(1, email); diff --git a/tests/club/wpia/gigi/pages/main/RegisterPageTest.java b/tests/club/wpia/gigi/pages/main/RegisterPageTest.java index 02404de9..71409295 100644 --- a/tests/club/wpia/gigi/pages/main/RegisterPageTest.java +++ b/tests/club/wpia/gigi/pages/main/RegisterPageTest.java @@ -82,6 +82,9 @@ public class RegisterPageTest extends ManagedTest { @Test public void testNoEmail() throws IOException { testFailedForm("fname=a&lname=b&pword1=ap&pword2=ap&day=1&month=1&year=1910&tos_agree=1&dp_agree=1"); + testFailedForm("fname=a&lname=b&email=e&pword1=ap&pword2=ap&day=1&month=1&year=1910&tos_agree=1&dp_agree=1"); + testFailedForm("fname=a&lname=b&email=e@&pword1=ap&pword2=ap&day=1&month=1&year=1910&tos_agree=1&dp_agree=1"); + testFailedForm("fname=a&lname=b&email=@d.ef&pword1=ap&pword2=ap&day=1&month=1&year=1910&tos_agree=1&dp_agree=1"); } @Test -- 2.39.2