From 0bf1ab6aa899f3d0ce80831c0cc0b5065f32bd7c Mon Sep 17 00:00:00 2001 From: Benny Baumann Date: Wed, 25 Feb 2015 23:24:13 +0100 Subject: [PATCH] Fix: Coverity, boolean compare in template's ifStatement --- src/org/cacert/gigi/output/template/IfStatement.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/org/cacert/gigi/output/template/IfStatement.java b/src/org/cacert/gigi/output/template/IfStatement.java index 39a89b80..0347a363 100644 --- a/src/org/cacert/gigi/output/template/IfStatement.java +++ b/src/org/cacert/gigi/output/template/IfStatement.java @@ -16,7 +16,7 @@ public final class IfStatement implements Outputable { public IfStatement(String variable, TemplateBlock body) { this.variable = variable; this.iftrue = body; - iffalse = null; + this.iffalse = null; } public IfStatement(String variable, TemplateBlock iftrue, TemplateBlock iffalse) { @@ -28,10 +28,12 @@ public final class IfStatement implements Outputable { @Override public void output(PrintWriter out, Language l, Map vars) { Object o = vars.get(variable); - if ( !(o == null || o == Boolean.FALSE)) { + + if ( !(o == null || Boolean.FALSE.equals(o))) { iftrue.output(out, l, vars); } else if (iffalse != null) { iffalse.output(out, l, vars); } } + } -- 2.39.2