From: Benny Baumann <BenBE1987@gmx.net>
Date: Tue, 20 Feb 2018 20:37:45 +0000 (+0100)
Subject: fix: resource leaks in OCSPIssuerManager
X-Git-Url: https://code.wpia.club/?p=gigi.git;a=commitdiff_plain;h=f8fd4a425309492e60c53133dc899ae3aa92914a;hp=985d31f75a724d141ff37bb678c28aaa474d5915

fix: resource leaks in OCSPIssuerManager

Change-Id: I15aa074af09c07b72ddb953fa8d1f63b6ae3eb88
---

diff --git a/src/club/wpia/gigi/ocsp/OCSPIssuerManager.java b/src/club/wpia/gigi/ocsp/OCSPIssuerManager.java
index 400737f0..36343371 100644
--- a/src/club/wpia/gigi/ocsp/OCSPIssuerManager.java
+++ b/src/club/wpia/gigi/ocsp/OCSPIssuerManager.java
@@ -225,7 +225,9 @@ public class OCSPIssuerManager implements Runnable {
                         if (ks.length() == 0) {
                             keys.load(null);
                         } else {
-                            keys.load(new FileInputStream(ks), "pass".toCharArray());
+                            try (FileInputStream ks_file = new FileInputStream(ks)) {
+                                keys.load(ks_file, "pass".toCharArray());
+                            }
                         }
                     } else {
                         // assuming ocsp is disabled
@@ -239,8 +241,8 @@ public class OCSPIssuerManager implements Runnable {
                 Map<String, OCSPIssuer> toServe = new HashMap<>();
 
                 scanAndUpdateCAs(f, keys, toServe);
-                try {
-                    keys.store(new FileOutputStream(ks), "pass".toCharArray());
+                try (FileOutputStream ks_file = new FileOutputStream(ks)) {
+                    keys.store(ks_file, "pass".toCharArray());
                 } catch (GeneralSecurityException e) {
                     throw new Error(e);
                 } catch (IOException e) {