From: INOPIAE <m.maengel@inopiae.de>
Date: Wed, 8 Feb 2017 08:27:58 +0000 (+0100)
Subject: Add a hint what the "Request reping" is used for on the email page
X-Git-Url: https://code.wpia.club/?p=gigi.git;a=commitdiff_plain;h=d7271af56f7c4f3381ea079f1be1a52124e1d241

Add a hint what the "Request reping" is used for on the email page

fixes issue #56

Change-Id: I518082eb4c95beed01b846690264d174757790dd
---

diff --git a/src/org/cacert/gigi/pages/account/mail/MailManagementForm.java b/src/org/cacert/gigi/pages/account/mail/MailManagementForm.java
index 87087b74..5d0ce7ec 100644
--- a/src/org/cacert/gigi/pages/account/mail/MailManagementForm.java
+++ b/src/org/cacert/gigi/pages/account/mail/MailManagementForm.java
@@ -14,6 +14,7 @@ import org.cacert.gigi.output.template.Form;
 import org.cacert.gigi.output.template.IterableDataset;
 import org.cacert.gigi.output.template.Template;
 import org.cacert.gigi.pages.Page;
+import org.cacert.gigi.util.TimeConditions;
 
 public class MailManagementForm extends Form {
 
@@ -86,6 +87,7 @@ public class MailManagementForm extends Form {
 
         };
         vars.put("emails", ds);
+        vars.put("maxMonth", TimeConditions.getInstance().getEmailPingMonths());
         t.output(out, l, vars);
     }
 }
diff --git a/src/org/cacert/gigi/pages/account/mail/MailManagementForm.templ b/src/org/cacert/gigi/pages/account/mail/MailManagementForm.templ
index 10d44328..2449bca1 100644
--- a/src/org/cacert/gigi/pages/account/mail/MailManagementForm.templ
+++ b/src/org/cacert/gigi/pages/account/mail/MailManagementForm.templ
@@ -8,7 +8,7 @@
   <tr>
     <td><?=_Default?></td>
     <td><?=_Status?></td>
-    <td><?=_Last successful verification?></td>
+    <td><?=_Last successful verification?>*</td>
     <td><?=_Address?></td>
     <td><?=_Delete?></td>
     <td><?=_Request reping?></td>
@@ -23,5 +23,8 @@
  		<td><button class="btn btn-primary" type="submit" name="reping" value="<?=$id?>"><?=_Request reping?></button></td>
  	</tr>
  <? } ?>
+  <tr>
+    <td colspan=6>* <?=_To issue certificates for an email address listed above, the last successful verification of the email address must not be older than ${maxMonth} months. Use "Request Reping" to start a new email verification.?></td>
+  </tr>
   </tbody>
 </table>
diff --git a/src/org/cacert/gigi/util/TimeConditions.java b/src/org/cacert/gigi/util/TimeConditions.java
index dce98001..b851dc9d 100644
--- a/src/org/cacert/gigi/util/TimeConditions.java
+++ b/src/org/cacert/gigi/util/TimeConditions.java
@@ -16,11 +16,14 @@ public class TimeConditions {
 
     private final int verificationMaxAgeMonths;
 
+    private final int emailPingMonths;
+
     private TimeConditions(Properties ppts) {
         testValidMonths = Integer.parseInt(ppts.getProperty("time.testValidMonths", "12"));
         reverificationDays = Integer.parseInt(ppts.getProperty("time.reverificationDays", "90"));
         verificationFreshMonths = Integer.parseInt(ppts.getProperty("time.verificationFreshMonths", "39"));
         verificationMaxAgeMonths = Integer.parseInt(ppts.getProperty("time.verificationMaxAgeMonths", "24"));
+        emailPingMonths = Integer.parseInt(ppts.getProperty("time.emailPingMonths", "6"));
     }
 
     public static synchronized TimeConditions getInstance() {
@@ -76,4 +79,13 @@ public class TimeConditions {
         return verificationMaxAgeMonths;
     }
 
+    /**
+     * Maximum time in months that an email address can be used for creating
+     * client certificates before a reping is neccessary
+     * 
+     * @return the configured number of months
+     */
+    public int getEmailPingMonths() {
+        return emailPingMonths;
+    }
 }
diff --git a/util-testing/org/cacert/gigi/pages/Manager.java b/util-testing/org/cacert/gigi/pages/Manager.java
index 3244bb42..38b45f6e 100644
--- a/util-testing/org/cacert/gigi/pages/Manager.java
+++ b/util-testing/org/cacert/gigi/pages/Manager.java
@@ -501,6 +501,7 @@ public class Manager extends Page {
         vars.put("reverificationDays", TimeConditions.getInstance().getVerificationLimitDays());
         vars.put("verificationFreshMonths", TimeConditions.getInstance().getVerificationMonths());
         vars.put("verificationMaxAgeMonths", TimeConditions.getInstance().getVerificationMaxAgeMonths());
+        vars.put("emailPingMonths", TimeConditions.getInstance().getEmailPingMonths());
 
         form.output(resp.getWriter(), getLanguage(req), vars);
     }
diff --git a/util-testing/org/cacert/gigi/pages/Manager.templ b/util-testing/org/cacert/gigi/pages/Manager.templ
index 8556d686..dcd6883d 100644
--- a/util-testing/org/cacert/gigi/pages/Manager.templ
+++ b/util-testing/org/cacert/gigi/pages/Manager.templ
@@ -125,4 +125,10 @@ Maximum time that a verification is accepted
 </td><td>
 <?=$verificationMaxAgeMonths?> months
 </td></tr>
+
+<tr><td>
+Maximum time before reping of email address needed
+</td><td>
+<?=$emailPingMonths?> months
+</td></tr>
 </table>