If we can’t open the Pwned Passwords database because the file does not
exist, there’s no need to print a detailed stack trace: the warning
message should be enough to gently inform the system administrator that
they can improve their security by installing the database. Any other
errors (e. g. permission errors) are still reported.
This is mainly motivated by the dozens of NoSuchFileException stack
traces in CI builds, which this commit should silence.
Change-Id: Id08afc1600a70acfc49b2c4335b533949413b09a
import java.math.BigInteger;
import java.nio.channels.FileChannel;
import java.nio.file.FileSystems;
+import java.nio.file.NoSuchFileException;
import java.nio.file.Path;
import java.security.KeyStore;
import java.security.MessageDigest;
throw new RuntimeException("Error while opening password hash database, refusing startup", e);
} else {
System.err.println("Error while opening password hash database, passwords will be checked only by strength");
- e.printStackTrace();
+ if (!(e instanceof NoSuchFileException)) {
+ e.printStackTrace();
+ }
return new PasswordStrengthChecker();
}
}