FIX: more Coverity, as charset, nullcheck, equals

diff --git a/src/org/cacert/gigi/email/EmailProvider.java b/src/org/cacert/gigi/email/EmailProvider.java
index d76fd6ef1d185f002b76a464717bb170e28035ea..6494bf8d65893a8a8c3f79f1a5d74f00c85ace02 100644 (file)
--- a/src/org/cacert/gigi/email/EmailProvider.java
+++ b/src/org/cacert/gigi/email/EmailProvider.java
@@ -119,7 +119,7 @@ public abstract class EmailProvider {
                         }
                         Socket s1 = ((SSLSocketFactory) SSLSocketFactory.getDefault()).createSocket(s, host, 25, true);
                         br = new BufferedReader(new InputStreamReader(s1.getInputStream(), "UTF-8"));
-                        pw = new PrintWriter(s1.getOutputStream());
+                        pw = new PrintWriter(new OutputStreamWriter(s1.getOutputStream(), "UTF-8"));
                         pw.print("EHLO www.cacert.org\r\n");
                         pw.flush();
                         if ( !Sendmail.readSMTPResponse(br, 250)) {

diff --git a/src/org/cacert/gigi/email/Sendmail.java b/src/org/cacert/gigi/email/Sendmail.java
index 3c915ab9229099af7d4b7f744b5e9e951ab40ef6..486f3c4efeedaf767cb69d2eb699e4d1b46c35a4 100644 (file)
--- a/src/org/cacert/gigi/email/Sendmail.java
+++ b/src/org/cacert/gigi/email/Sendmail.java
@@ -3,6 +3,7 @@ package org.cacert.gigi.email;
 import java.io.BufferedReader;
 import java.io.IOException;
 import java.io.InputStreamReader;
+import java.io.OutputStreamWriter;
 import java.io.PrintWriter;
 import java.net.Socket;
 import java.security.GeneralSecurityException;
@@ -26,7 +27,7 @@ public class Sendmail extends EmailProvider {
 
         String[] bits = from.split(",");
 
-        try (Socket smtp = new Socket("localhost", 25); PrintWriter out = new PrintWriter(smtp.getOutputStream()); BufferedReader in = new BufferedReader(new InputStreamReader(smtp.getInputStream(), "UTF-8"));) {
+        try (Socket smtp = new Socket("localhost", 25); PrintWriter out = new PrintWriter(new OutputStreamWriter(smtp.getOutputStream(), "UTF-8")); BufferedReader in = new BufferedReader(new InputStreamReader(smtp.getInputStream(), "UTF-8"));) {
             readSMTPResponse(in, 220);
             out.print("HELO www.cacert.org\r\n");
             out.flush();

diff --git a/src/org/cacert/gigi/localisation/Language.java b/src/org/cacert/gigi/localisation/Language.java
index 4c6e39012094281c3736c5e4a73649b93c6bbe80..6a48f5aaacb1cf0ce785ffdb6ee7f4729bb7b8c9 100644 (file)
--- a/src/org/cacert/gigi/localisation/Language.java
+++ b/src/org/cacert/gigi/localisation/Language.java
@@ -27,12 +27,15 @@ public class Language {
     static {
         LinkedList<Locale> supported = new LinkedList<>();
         File locales = new File("locale");
-        for (File f : locales.listFiles()) {
-            if ( !f.getName().endsWith(".xml")) {
-                continue;
+        File[] listFiles = locales.listFiles();
+        if (listFiles != null) {
+            for (File f : listFiles) {
+                if ( !f.getName().endsWith(".xml")) {
+                    continue;
+                }
+                String language = f.getName().split("\\.", 2)[0];
+                supported.add(getLocaleFromString(language));
             }
-            String language = f.getName().split("\\.", 2)[0];
-            supported.add(getLocaleFromString(language));
         }
         Collections.sort(supported, new Comparator<Locale>() {
 

diff --git a/src/org/cacert/gigi/output/template/IfStatement.java b/src/org/cacert/gigi/output/template/IfStatement.java
index fbd83bcfc799c70059b6f226f225dd84f5bab6e2..39a89b80d515d8cfb69f4b3376e7f99973d1c45d 100644 (file)
--- a/src/org/cacert/gigi/output/template/IfStatement.java
+++ b/src/org/cacert/gigi/output/template/IfStatement.java
@@ -28,7 +28,7 @@ public final class IfStatement implements Outputable {
     @Override
     public void output(PrintWriter out, Language l, Map<String, Object> vars) {
         Object o = vars.get(variable);
-        if ( !(o == Boolean.FALSE || o == null)) {
+        if ( !(o == null || o == Boolean.FALSE)) {
             iftrue.output(out, l, vars);
         } else if (iffalse != null) {
             iffalse.output(out, l, vars);

diff --git a/src/org/cacert/gigi/pages/PolicyIndex.java b/src/org/cacert/gigi/pages/PolicyIndex.java
index d6416b69069ff023e888046bb59dff513116eede..25e69446c91e9cc824876e547cc94da921ca00ca 100644 (file)
--- a/src/org/cacert/gigi/pages/PolicyIndex.java
+++ b/src/org/cacert/gigi/pages/PolicyIndex.java
@@ -21,18 +21,21 @@ public class PolicyIndex extends Page {
     public void doGet(HttpServletRequest req, HttpServletResponse resp) throws IOException {
         PrintWriter out = resp.getWriter();
         out.println("<ul>");
-        for (File f : root.listFiles()) {
-            String name = f.getName();
-            if ( !name.endsWith(".html")) {
-                continue;
+        File[] files = root.listFiles();
+        if (files != null) {
+            for (File f : files) {
+                String name = f.getName();
+                if ( !name.endsWith(".html")) {
+                    continue;
+                }
+                String display = name.replaceFirst("\\.html$", "");
+
+                out.print("<li><a href='");
+                out.print(name);
+                out.print("'>");
+                out.print(display);
+                out.println("</a></li>");
             }
-            String display = name.replaceFirst("\\.html$", "");
-
-            out.print("<li><a href='");
-            out.print(name);
-            out.print("'>");
-            out.print(display);
-            out.println("</a></li>");
         }
         out.println("</ul>");
     }

diff --git a/src/org/cacert/gigi/util/KeyStorage.java b/src/org/cacert/gigi/util/KeyStorage.java
index 9b3f11eb14dfd4a901a2f1bb7212382770f6f08e..7ce0d2853995c8983248093c11982c161de444dc 100644 (file)
--- a/src/org/cacert/gigi/util/KeyStorage.java
+++ b/src/org/cacert/gigi/util/KeyStorage.java
@@ -10,13 +10,17 @@ public class KeyStorage {
 
     public static File locateCrt(int id) {
         File parent = new File(crt, (id / 1000) + "");
-        parent.mkdirs();
+        if ( !parent.exists() && !parent.mkdirs()) {
+            throw new Error("cert folder could not be created");
+        }
         return new File(parent, id + ".crt");
     }
 
     public static File locateCsr(int id) {
         File parent = new File(csr, (id / 1000) + "");
-        parent.mkdirs();
+        if ( !parent.exists() && !parent.mkdirs()) {
+            throw new Error("csr folder could not be created");
+        }
         return new File(parent, id + ".csr");
     }
 }