logger::error( "Invalid Message" );
break;
}
- } catch( const char* msg ) {
- logger::error( msg );
+ } catch( const std::exception& msg ) {
+ logger::error( msg.what() );
return std::shared_ptr<SignedCertificate>();
}
}
int dlen = BIO_write( bios.get(), buf, len );
if( dlen <= 0 ) {
- throw "Memory error.";
+ throw std::runtime_error("Memory error.");
}
len -= dlen;
buf += dlen;
}
- std::shared_ptr<X509> pem( PEM_read_bio_X509( bios.get(), NULL, 0, NULL ) );
+ std::shared_ptr<X509> pem( PEM_read_bio_X509( bios.get(), NULL, 0, NULL ), X509_free );
if( !pem ) {
- throw "Pem was not readable";
+ throw std::runtime_error("Pem was not readable");
}
- std::shared_ptr<BIGNUM> ser( ASN1_INTEGER_to_BN( pem->cert_info->serialNumber, NULL ), BN_free );
+ std::shared_ptr<BIGNUM> ser( ASN1_INTEGER_to_BN( X509_get_serialNumber(pem.get()), NULL), BN_free );
std::shared_ptr<char> serStr(
BN_bn2hex( ser.get() ),
[]( char* p ) {
std::string date;
if( static_cast<RecordHeader::SignerResult>( head.command ) != RecordHeader::SignerResult::REVOKED ) {
- throw "Protocol violation";
+ throw std::runtime_error("Protocol violation");
}
const unsigned char* buffer2 = reinterpret_cast<const unsigned char*>( payload.data() );
payload = parseCommandChunked( head, conn );
if( static_cast<RecordHeader::SignerResult>( head.command ) != RecordHeader::SignerResult::FULL_CRL ) {
- throw "Protocol violation";
+ throw std::runtime_error("Protocol violation");
}
std::string name_bak = ca->path + std::string( "/ca.crl.bak" );
crl = std::make_shared<CRL>( name_bak );
if( crl->verify( ca ) ) {
- writeFile( tgtName, crl->toString() );
- if( remove( name_bak.c_str() ) != 0 ){
- logger::warn( "Removing old CRL failed" );
+ if( rename( name_bak.c_str(), tgtName.c_str() ) != 0 ){
+ logger::warn( "Moving new CRL over old CRL failed" );
}
logger::note( "CRL is now valid again" );
} else {